Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer previewer ls colorized #505

Merged

Conversation

Conni2461
Copy link
Member

@Conni2461 Conni2461 commented Feb 6, 2021

Need help with color groups otherwise should be done.

Also probably we should create Telescope hl_groups for that. I am open for default links :)
Also i need to think about the code 😆 Just wrote that in 30 mins so might not be optimal in terms of everything

Before After
2021-02-06_13-18 t0NvTME

Edit: new idea plenary already has the sections so why not use that 🤣

@Conni2461 Conni2461 added the Buffer Previewer Something with the buffer previewer label Feb 6, 2021
@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch 2 times, most recently from baa79e4 to f9781aa Compare February 6, 2021 17:08
@Conni2461
Copy link
Member Author

@elianiva Can you retest now requires nvim-lua/plenary.nvim#63

We already kinda already have the section start and end index in scandir.ls so we should just do it there and pass it down.

@elianiva
Copy link
Member

elianiva commented Feb 7, 2021

just tested it out, works great!

@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch from f9781aa to 2a82c8a Compare February 7, 2021 12:54
plugin/telescope.vim Outdated Show resolved Hide resolved
@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch from 2a82c8a to ad522df Compare February 7, 2021 14:30
@Conni2461
Copy link
Member Author

Conni2461 commented Feb 7, 2021

@elianiva Can you retest? Needs a new version of nvim-lua/plenary.nvim#63 as well. Some more bugfixes and links are now shown and resolved like this: a -> b and highlight only a
2021-02-07_15-30

CC @timbedard might be interesting for you as well :) Just because we talked a lot about that ls earlier :)

Edit: Everybody that tests it. Thank you very much :)

@qbedard
Copy link

qbedard commented Feb 7, 2021

Neat! Yeah, I'll pull it down today or tomorrow and give it a go.

@elianiva
Copy link
Member

elianiva commented Feb 7, 2021

very cool! now it works with symlinks

@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch from ad522df to da511b7 Compare February 7, 2021 14:54
@Conni2461
Copy link
Member Author

Last small update to plenary. It now aligns username and group correctly :) I don't have a before picture but i didn't look good 😆
image

@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch from da511b7 to ff08e4f Compare February 9, 2021 17:33
@Conni2461 Conni2461 force-pushed the buffer_previewer_ls_colorized branch from ff08e4f to 4c0b940 Compare February 9, 2021 17:40
@Conni2461 Conni2461 merged commit 09d1e3a into nvim-telescope:master Feb 12, 2021
@Conni2461 Conni2461 deleted the buffer_previewer_ls_colorized branch February 12, 2021 21:32
tjdevries pushed a commit that referenced this pull request Feb 24, 2021
Requires up to date plenary version
@Conni2461 Conni2461 added this to Done in 0.1 Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buffer Previewer Something with the buffer previewer
Projects
No open projects
0.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants