Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preview for files which spaces in names. #35

Merged
merged 1 commit into from
Sep 5, 2020
Merged

added preview for files which spaces in names. #35

merged 1 commit into from
Sep 5, 2020

Conversation

SubeetKD
Copy link
Contributor

@SubeetKD SubeetKD commented Sep 5, 2020

No description provided.

@tjdevries
Copy link
Member

Ah, this probably fixes the problem, but what we might want to do is probably switch over to the way of sending a list to termopen or something. That will handle auto-escaping for us (like if the file has a " in it, i think the current way will break, for example).

What do you think about that?

@SubeetKD
Copy link
Contributor Author

SubeetKD commented Sep 5, 2020

Yes you are right it will break. I don't know much of lua and vimscript so I don't think I can solve this.

@SubeetKD SubeetKD closed this Sep 5, 2020
@tjdevries tjdevries reopened this Sep 5, 2020
@tjdevries
Copy link
Member

That's ok, this is still a good improvement! We can try and fix the other thing later. Thanks for the PR!!

@tjdevries tjdevries merged commit d3c9b65 into nvim-telescope:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants