-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactors transform_path and allow smart
to be used in conjunction with filename_first
#3152
feat: refactors transform_path and allow smart
to be used in conjunction with filename_first
#3152
Conversation
smart
to be used in conjunction with filename_first
smart
to be used in conjunction with filename_first
@Conni2461 I left a comment related to one of your suggestions. Can you let me know what you favor yourself? I'll do follow up based on your reply. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general feedback, you should start looking at your diffs after you've submitted them. this took way too many iterations and so far I've only ever looked over it superficially
Thank you for the feedback! I'll go through the commits more carefully. There's some feedback on my side as well, though. As every codebase is different, it takes some time to understand what the maintainers expect. If I see a public method |
Can you add a comment like that (i think there are more functions in that file but i cant check right now, i am on mobile and tbh it doesnt matter), ill test that change tomorrow, after that, its good to go. Thanks :) |
Thanks! @Conni2461 I've checked all the methods and added a comment stating why it's public, even though it's only used within the utils file itself. One question, though. I noticed that there are 2 variants that look the same to me:
They seem to do the exact same thing, but with a different flavour of how it's written. I've tested this with the code below in and the function is callable: local utils = {}
function utils.hello_world()
print("hello world!")
end
utils.hello_world() Just wanted to check with you whether these are indeed just flavours of the same thing. |
thanks :) |
Description
I've cleaned up
transform_path
:path_filename_first
,path_truncate
, etc.smart
we would not be able to runfilename_first
afterwards.Smart pre-PR
Smart post-PR
The directory can now be separated with the following configuration:
Type of change
smart
to be used in conjunction withfilename_first
How Has This Been Tested?
Configuration:
OSX Sonoma 14.4.1
Checklist: