fix(lsp): handle URI in item_to_location
#3144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on my comment in #3137 regarding the broken jump to Java classes such as
java.lang.String
because the JDT URI is not a file name. Withitem.filename
beingjdt:https://contents/java.base/java.lang/String.class...
, the callvim.uri_from_fname(item.filename)
initem_to_location
would convert the JDT URI into an invalid URI by addingfile:https://
in front ofjdt:https://
and encode the already encoded URI again. The jump would fail as a result.This is an attempt to fix the issue by applying filename to URI transformation only if
item.filename
is not a URI.Error message:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
java.lang.String
(JDT URI handled by nvim-jdtls)Configuration:
Neovim version (nvim --version):
NVIM v0.10.0
Build type: RelWithDebInfo
LuaJIT 2.1.1707061634
Operating system and version:
Linux (Fedora 40)
Checklist: