fix(previewer): improve binary mime type check #3083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: mime type for a ts/js file can either return
text/plain
orapplication/javascript
based on the contents of the file. Previously, this meantapplication/javascript
would be considered "possibly binary". This, in conjunction with howvim.filetype.match
does not give a result for a filename that ends in.ts
, would lead to a typescript file taking the path ofcheck_mime_type
and eventuallymime_hook
.Solution: Include
application/javascript
as a non-binary file type during mime type check.closes #3068