fix(picker): set current_line
state earlier
#3052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
current_line
global state earlier in the event loop rather than inget_results_completor
. This makes it safer to accesscurrent_line
earlier (eg. for building an entry).closes #3051
I'm not super confident this is safe to do without some unintended side effects. I've experienced some finicky race conditions with the
picker:_get_prompt
before so I'll use this branch for a bit.