Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rework ci tests to include windows #3011

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

jamestrew
Copy link
Contributor

  • add windows runner as part of test ci and fix any windows sensitive tests
  • tweak Makefile & minimal_init so running tests locally isn't dependent on local directory structure (I wanted to do this with docgen as well but it's so flaky and impossible on nightly neovim anyways)

close #3000

ps. sorry if you got spammed by failed ci notifs

@jamestrew
Copy link
Contributor Author

macos nightly failure: rhysd/action-setup-vim#30

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Conni2461
Copy link
Member

Conni2461 commented Apr 2, 2024

Yeah generally speaking we can add a windows test runner. Currently no checks did run. is this correct?

image

Edit: found it nvm, forgot about that 😅
image

tweak Makefile & minimal_init so running tests locally isn't dependent on local directory structure (I wanted to do this with docgen as well but it's so flaky and impossible on nightly neovim anyways)

This is the only thing i actually dont like. We never wanna download dependencies for the user who runs the tests locally. We only wanna do this in an controlled environment, github runner. This was never an issue in the past 2.5 years so i dont see a reason to change that, users who actually have a different directory structure, should probably just manually edit the minimal rc. Thats far simpler than dealing with a "complex" Makefile which is a pain (see telescope-fzf-native.nvim, which only has to compile a singe c source file ...)

Makefile Outdated Show resolved Hide resolved
@jamestrew jamestrew force-pushed the ci-rework branch 2 times, most recently from c7da09f to 1691f1d Compare April 5, 2024 03:14
- add windows runner as part of test ci and fix any windows sensitive
  tests

- tweak Makefile & minimal_init so running tests locally isn't dependent
  on local directory structure (I wanted to do this with docgen as well
  but it's so flaky and impossible on nightly neovim anyways)
@jamestrew jamestrew force-pushed the ci-rework branch 2 times, most recently from 9c6294e to 14b7312 Compare April 9, 2024 02:38
@jamestrew jamestrew requested a review from Conni2461 April 9, 2024 02:42
@Conni2461
Copy link
Member

thanks :)

@Conni2461 Conni2461 merged commit 4d4ade7 into nvim-telescope:master Apr 13, 2024
@jamestrew jamestrew deleted the ci-rework branch April 14, 2024 14:20
Conni2461 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add windows to test ci
2 participants