Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin.lsp): extra No Name buffer opening with jump_type #2990

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jamestrew
Copy link
Contributor

closes #2368

Just needed to pass the filename to these window/tab opening commands so that they don't needlessly create an empty buffer.

@Frederick888
Copy link

I can confirm this fixed my issue. Thank you!

@jamestrew jamestrew merged commit 5730b95 into nvim-telescope:master Mar 18, 2024
6 checks passed
@jamestrew jamestrew deleted the fix/lsp-jump branch March 18, 2024 13:42
@divaltor
Copy link

@jamestrew This PR breaks gd behavior of LazyVim keymap

image

@jamestrew
Copy link
Contributor Author

@divaltor Thanks for catching that and mentioning it. I just put in a fix.

@jamestrew jamestrew added the backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat) label Mar 21, 2024
Conni2461 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jump_type of split will open a [No Name] ("new") buffer in addition to splitting window with definition
3 participants