fix(lsp): incoming/outgoing_call range locations #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation uses the incorrect lsp result fields for generating call site locations resulting in incomplete and incorrect results.
|
this did work previously, so it might be related to the neovim version?! so not sure regarding to the backport |
|
I looked at the neovim lsp handler for call_hierarchy and it hasn't changed since 2020 and my fix is identical to it. I'll double check on neovim 0.7 but I think it should be safe to backport. |
|
I really appreciate you taking a look at this issue :). |
Conni2461
pushed a commit
that referenced
this pull request
May 20, 2024
Previous implementation uses the incorrect lsp result fields for generating call site locations resulting in incomplete and incorrect results. (cherry picked from commit 8cd58c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation uses the incorrect lsp result fields for generating call site locations resulting in incomplete and incorrect results.
closes #2939