Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: help #2556

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: help #2556

merged 1 commit into from
Jun 8, 2023

Conversation

Conni2461
Copy link
Member

@Conni2461 Conni2461 commented Jun 8, 2023

CC @clason

fixes regression in #2551

currently anon functions aren't figured out like before

@Conni2461
Copy link
Member Author

problem is with functions that aren't telescope actions we need to open the source file and check the content.

But with the new implementation we need to figure out the desc on mapping register, not sure if its worth to do that

@Conni2461
Copy link
Member Author

but it might actually be just a handful of cases so it might not even have an impact

@Conni2461
Copy link
Member Author

got a better idea, we could just serialize the debug.getinfo into the desc so we can still "scrape" the information on action open

@Conni2461 Conni2461 force-pushed the fix/help branch 2 times, most recently from 65d598d to a148377 Compare June 8, 2023 19:24
@Conni2461
Copy link
Member Author

okay, think i got it back to the previous functionality. @clason do you have a sec and could test it

@clason
Copy link
Contributor

clason commented Jun 8, 2023

Afk right now but will the moment I get back. But significant simplification is worth dropping the feature, as far as I'm concerned.

@Conni2461
Copy link
Member Author

nah i think we should keep it, even though i dont use it, it helps new users to get going, so it has a purpose.

The new hack isn't that bad ^^ and its only used to store information about anonymous functions which isn't that common anyway

@clason
Copy link
Contributor

clason commented Jun 8, 2023

And it works nicely :)

@Conni2461
Copy link
Member Author

thx for testing :)

@Conni2461 Conni2461 merged commit 4226740 into nvim-telescope:master Jun 8, 2023
@Conni2461 Conni2461 deleted the fix/help branch June 8, 2023 21:10
Conni2461 added a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants