Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: simplify vimgrep_arguments args (#2440)" #2488

Merged
merged 1 commit into from
May 7, 2023

Conversation

jamestrew
Copy link
Contributor

@jamestrew jamestrew commented May 2, 2023

This reverts commit cfe6df6.

Description

It appears that the commit above is causing issues in certain instances when using grepping pickers.
The --vimgrep option seems to be the culprit.

BurntSushi doesn't really recommend using --vimgrep:

--vimgrep is itself a strange thing, and is IMO legacy. It would probably be better if text editor plugins used ripgrep's --json flag to get structured matches. This is what VS Code does, for example.

Issue is reproducible live grepping in this repo/directory: https://github.com/swagger-api/swagger-ui/tree/master/dist

Fixes #2482

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Tested live grepping in the swagger repo with/without --vimgrep option

Configuration:

  • Neovim version (nvim --version): NVIM v0.10.0-dev-19+g339011f59
  • Operating system and version: Linux archlinux 6.2.12-arch1-1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@tjdevries
Copy link
Member

Thanks! I haven't had a chance to reproduce everything, but I do remember something like this awhile ago. Thanks for the PR

@jamestrew jamestrew deleted the fix/vimgrep branch May 7, 2023 05:01
Conni2461 pushed a commit that referenced this pull request May 14, 2023
abelmul pushed a commit to abelmul/telescope.nvim that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live_grep makes linux computer run out of memory and freeze completely
2 participants