fix: selected icon highlight with color_devicons to false

[Diaoul]

Description

The background color is off on selected text

Type of change

• Bug fix

How Has This Been Tested?

Locally

Configuration:

• Neovim version (nvim --version): NVIM v0.9.0-dev-16-g56998feeb
• Operating system and version: Arch Linux

Checklist:

• My code follows the style guidelines of this project (stylua)
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (lua annotations)

[Diaoul]

Also note that this is now possible to do globally at the nvim-web-devicons level with nvim-tree/nvim-web-devicons#157

local devicons = require "nvim-web-devicons"
devicons.setup {
    override = {
        default_icon = {
            icon = "",
            color = "#ebdbb2",
            cterm_color = "223",
        },
    },
    color_icons = false,
}

And it will pick the default icon's color (not nil though, so it's a bit less flexible that the option in telescope)

[T-727]

Hey,
I tried all 4 combos of color_devicons and color_icons options and couldn't reproduce this,
could you provide steps/minimal-config please?

[Diaoul]

Sorry I did not include that in the first place. Here is something I just used with catppuccin theme to make it not look too bad.

Configuration

        use { "wbthomason/packer.nvim" }
        use { "nvim-lua/plenary.nvim" }
        use {
            "kyazdani42/nvim-web-devicons",
            config = function()
              local devicons = require "nvim-web-devicons"
              devicons.setup {
                  color_icons = true,
              }
            end,
        }
        use {
            "nvim-telescope/telescope.nvim",
            config = function()
              require("telescope").setup {
                  defaults = {
                      color_devicons = true,
                  },
              }
            end,
        }
         use {
             "catppuccin/nvim",
             as = "catppuccin",
             config = function()
              vim.g.catppuccin_flavour = "mocha"
              require("catppuccin").setup { }
              vim.cmd [[colorscheme catppuccin]]
             end,
         }

Steps

• Just open telescope (find files or something)

Output

Telescope at true (default) and devicons true (default):

Telescope at false and devicons true (default):

👉 I think you need :PackerCompile in between configuration changes.

[Conni2461]

thanks :)

Shouldn't we also drop TelescopeResultsFileIcon from plugin/telescope.lua, the hl group is only used here

[Diaoul]

Good catch 👍