Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): update buffer previewer to upstream changes #2150

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

clason
Copy link
Contributor

@clason clason commented Aug 27, 2022

neovim/neovim#19931 removed _get_hl_from_capture(id) since captures are now implicitly mapped to highlight groups with the same name.

Fixes #2149

(PSA: "Neovim master" always means "latest HEAD" -- this will intentionally break on older nightlies.)

@clason clason force-pushed the clason-patch-1 branch 2 times, most recently from 7598e9d to 16b44df Compare August 27, 2022 11:17
@Conni2461
Copy link
Member

Thanks :) Tested it, seems to work. Just a small nit, that might be worth fixing, after that we can merge.

(PSA: "Neovim master" always means "latest HEAD" -- this will intentionally break on older nightlies.)

We say: "Neovim (v0.7.0) or the latest neovim nightly commit is required for telescope.nvim to work." so i am fine with that

(Maybe that should say 0.7.2 or 0.7.*, haven't updated our readme since the last release 😆)

@clason
Copy link
Contributor Author

clason commented Aug 27, 2022

As long as we're agreed that we only support the latest release and the latest commit on master :)

By the way, there's a has('nvim-0.7') check at the top of this file -- isn't that redundant with the one in plugin/telescope.lua?

neovim/neovim#19931 removed `_get_hl_from_capture(id)` since captures are now implicitly mapped to highlight groups with the same name.
@Conni2461
Copy link
Member

By the way, there's a has('nvim-0.7') check at the top of this file -- isn't that redundant with the one in plugin/telescope.lua?

Yeah i also noticed this, but for some recent never removed it 😬

Thanks again :)

@Conni2461 Conni2461 merged commit b923665 into master Aug 27, 2022
@Conni2461 Conni2461 deleted the clason-patch-1 branch August 27, 2022 13:29
Conni2461 pushed a commit that referenced this pull request Sep 4, 2022
neovim/neovim#19931 removed `_get_hl_from_capture(id)` since captures are now implicitly mapped to highlight groups with the same name.
(cherry picked from commit b923665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current_buffer_fuzzy_find preview with treesitter highlighting broken on Neovim 0.8
2 participants