Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default entry_maker not set properly #2116

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

mnowotnik
Copy link
Contributor

@mnowotnik mnowotnik commented Aug 8, 2022

Description

Not setting entry_maker explicitly should fallback gracefully, Currently, it doesn't work, because
it's being set to make_entry.gen_from_string and make_entry.gen_from_string is entry_maker factory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran a script:

  pickers.new(opts, {
    finder = finders.new_dynamic({fn=function(_)
      return {"a","b","c"}
    end}):find()

Configuration:

  • Neovim version 0.7.2
  • Operating system and version: Ubuntu 20.04

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

make_entry.gen_from_string is entry_maker factory
@Conni2461 Conni2461 merged commit 12c08bf into nvim-telescope:master Aug 13, 2022
Conni2461 pushed a commit that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants