Add a method to show loclist #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdevries
reviewed
Sep 1, 2020
lua/telescope/builtin.lua
Outdated
| if next(locations) == nil then | ||
| locations = vim.fn.getloclist(0) | ||
| for _, value in pairs(locations) do | ||
| value.filename = vim.fn.bufname("%") |
There was a problem hiding this comment.
vim.api.nvim_buf_get_name(0) would be better
tjdevries
reviewed
Sep 1, 2020
lua/telescope/builtin.lua
Outdated
| @@ -112,6 +112,13 @@ end | |||
|
|
|||
| builtin.quickfix = function(opts) | |||
There was a problem hiding this comment.
Can you add an opt for loclist_fallback?
There was a problem hiding this comment.
Or.... hmm, maybe what we want is just two different functions.
There was a problem hiding this comment.
They mean very different things.
singalhimanshu
force-pushed
the
master
branch
from
0c853b4
to
a5d3f95
Compare
singalhimanshu
changed the title
|
I can add the info about this in README.md if you think the implementation is okay. |
tjdevries
reviewed
Sep 2, 2020
lua/telescope/builtin.lua
Outdated
| local locations = vim.fn.getloclist(0) | ||
|
|
||
| for _, value in pairs(locations) do | ||
| value.filename = vim.api.nvim_buf_get_name(0) |
There was a problem hiding this comment.
probably only need to get this once. Just for perf that doesn't matter.
singalhimanshu
force-pushed
the
master
branch
2 times, most recently
from
09aab78
to
c76d832
Compare
singalhimanshu
force-pushed
the
master
branch
from
c76d832
to
c11a661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.