Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_status does not use defaults.path_display #2973

Closed
itsramiel opened this issue Mar 4, 2024 · 5 comments
Closed

git_status does not use defaults.path_display #2973

itsramiel opened this issue Mar 4, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@itsramiel
Copy link

Description

I am trying to change defaults.path_display. Other pickers like find_files and live_grep are affected by this changes but not git_status.

I have seen that this issue has been reported before: #2712 and #2658 and that a pr was made to address it: #2881

but I guess there is a regression or something?

Note that:

  pickers = {
    git_status = { path_display = {"truncate"}, },
  },

also does not work

Neovim version

NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1703358377

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.9.5/share/nvim"

Run :checkhealth for more info


### Operating system and version

Macos 14.3.1

### Telescope version / branch / rev

tag 0.1.5

### checkhealth telescope

```markdown
==============================================================================
telescope: require("telescope.health").check()

Checking for required plugins ~
- OK plenary installed.
- OK nvim-treesitter installed.

Checking external dependencies ~
- OK rg: found ripgrep 14.1.0
- OK fd: found fd 9.0.0

===== Installed extensions ===== ~

Telescope Extension: `textcase` ~
- No healthcheck provided



### Steps to reproduce

After installing telescope with minal config describe below try to open git_status, then path_display is not set to `truncate` comapred to find_files which does truncate

### Expected behavior

I expect git_status to use the defaults.path_display

### Actual behavior

Git status:
<img width="342" alt="image" src="https://github.com/nvim-telescope/telescope.nvim/assets/80689446/2ec8110a-2acf-47e7-92cc-f9dbe468e54b">

Find files:
<img width="343" alt="image" src="https://github.com/nvim-telescope/telescope.nvim/assets/80689446/d335f5ad-31c9-425f-8643-9829b4a2f8ed">


### Minimal config

```Lua
Minimal setup with lazy:


return {
	"nvim-telescope/telescope.nvim",
	tag = "0.1.5",
	-- or                              , branch = '0.1.x',
	dependencies = { "nvim-lua/plenary.nvim" },
	config = function()
		local telescope = require("telescope")
		local builtin = require("telescope.builtin")

		telescope.setup({
			defaults = {
				path_display = {"truncate"},
			},
		})
@itsramiel itsramiel added the bug Something isn't working label Mar 4, 2024
@jamestrew
Copy link
Contributor

I believe the PR that fixed it simply isn't a part of any stable release yet.
@Conni2461 maybe it's time for 0.1.6

@itsramiel
Copy link
Author

How can I change my installation to use the latest?

@Conni2461
Copy link
Member

I can check what we can backport and do a new release later today

@jamestrew
Copy link
Contributor

@itsramiel just remove (or increment once 0.1.6 comes out) the tag field in your lazy config for telescope

return {
    'nvim-telescope/telescope.nvim', 
    tag = '0.1.5', -- <-- this
    dependencies = { 'nvim-lua/plenary.nvim' }
}

@Conni2461
Copy link
Member

part of 0.1.6: https://github.com/nvim-telescope/telescope.nvim/releases/tag/0.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants