Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path_display options do NOT work with extensions and some other builtins #2712

Closed
searleser97 opened this issue Sep 21, 2023 · 6 comments · Fixed by #2881
Closed

path_display options do NOT work with extensions and some other builtins #2712

searleser97 opened this issue Sep 21, 2023 · 6 comments · Fixed by #2881
Labels
bug Something isn't working

Comments

@searleser97
Copy link

searleser97 commented Sep 21, 2023

Description

display_path options like shorten, truncate, etc do not work with some telescope extensions and other builtin features,

Take a look at the following 2 comments

#895 (comment)

Neovim version

Beta-latest

Operating system and version

Ubuntu 22.04

Telescope version / branch / rev

latest

checkhealth telescope

All plugins listed here are installed

Steps to reproduce

Described in description box

Expected behavior

display path options should work with plugins and other builtins not just find_files

Actual behavior

display path options don't work with extensions and other builtins

@searleser97 searleser97 added the bug Something isn't working label Sep 21, 2023
@jamestrew jamestrew changed the title display_path options do NOT work with extensions and some other builtins path_display options do NOT work with extensions and some other builtins Sep 21, 2023
@jamestrew
Copy link
Contributor

yeah this is a known issue. just haven't had the time.
also related #2658

@searleser97
Copy link
Author

Also this is related issue #2408

@delphinus
Copy link
Contributor

@searleser97 FYI: The current build of frecency supports path_display. :Telescope frecency path_display={'smart'} should work, for example.

@delphinus
Copy link
Contributor

delphinus commented Sep 22, 2023

Sorry, this issue means that the default setting of telescope.nvim is ignored in some pickers (like frecency).

telescope.setup {
  defaults = { path_display = { "shorten" } },
}
" This is shorten
:Telescope frecency path_display={"shorten"}

" But this is NOT shorten
:Telescope frecency

I will fix this.

@searleser97
Copy link
Author

I think it also doesn't work with this other plugin https://github.com/smartpde/telescope-recent-files so you guys can test with a plugin where it doesn't work

@jamestrew
Copy link
Contributor

I fixed this for git_status but for extensions, they will have to add support for it themselves.
It should be just a one line change to add support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants