Fixes and tests #36
Merged
Fixes and tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were ported from the go version. And when running them a couple of issues were found and fixed.
The tests that were testing for returned positions did not check the whole array. This fixes that, and also verifies that the length matches.
|
Ah, sorry, I did not run the lua tests, I will try to do that now and fix them |
The correct score is 54 16 + 2 * 8 - 3 - 2 * 1 + 16 - 3 - 2 * 1 + 16 = 54
|
Yes the test was wrong, the correct score is 54 |
|
You are right. This is awesome thank you very much :) I never expected anyone to look at my code so i dont know what to say 😆 Sorry that you had to deal with my testing framework i was just playing around with stuff. I am still learning c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the algorithm was not quite working right so I ported some tests from the Go version and made some fixes. I also improved the position based tests, which previously did not check for the whole expectation array.