Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make longer example collapsible #857

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nhat-vo
Copy link
Collaborator

@nhat-vo nhat-vo commented Apr 9, 2023

Not sure if this is a good idea, but I find the longer example section in the README too long to scroll through, making it hard to get to the next part of the guide.

@miversen33
Copy link
Collaborator

I wonder if instead of doing that, we opt for a Table of contents at the top of the README?

I don't have any strong opinions one way or the other, IMO this is also fine. I'm just not sure which is "better", if either really are. I could also see users not realizing there is a configuration shown and us having to point them to "click the expand button the readme to see the config" (regardless of it literally saying that on the readme)

If we do go with this, I would change the verbiage from "Click to View" to something more specific. Like "Click to view Packer.nvim example configuration"

Again though, I don't have strong feelings in any direction here lol

@nhat-vo
Copy link
Collaborator Author

nhat-vo commented Apr 9, 2023

@miversen33 Thanks for the comments 😁. IMO the README file serves more as an overview of the project, and detailed configs should be put into the help docs and the wiki. In that sense, I think it is better to hide detailed configs like this as collapsible or move it to the wiki, so that's why I create this PR.

I agree with your point on adding a ToC, but github has a good builtin one already, and (maybe I'm biased) I think README is generally viewed through github.

image

@cseickel
Copy link
Contributor

I think I like it because too many people just copy and paste the whole thing and then don't change anything, which they really shouldn't. In that way it might prevent some of that by not having it immediately visible.

On the other hand, some portion of users will never see it and this may produce some extra issues... Let me think about this a little.

@nhat-vo
Copy link
Collaborator Author

nhat-vo commented Apr 17, 2023

I think the wiki would also be a good place to put this. We can add more references to the wiki so that users will come across this when they want more advanced configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants