feat: Uniform way of closing popup window #1361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseickel
reviewed
Feb 23, 2024
| win:map("n", "<enter>", function(bufnr) | ||
| win:unmount() | ||
| end, { noremap = true }) | ||
| local exit_keys = { "<esc>", "<enter>", "q" } |
There was a problem hiding this comment.
This is reasonable. The only issue is that now the message on line 92 is out of sync with the mappings.
|
Are you sure this is what you want? I don't think the PR title is accurate. This does not change anything to the help window |
|
@Fildo7525 Any updates? |
|
I want to make a patch for exporting the keymaps to config. However, I do not have time now. |
|
Shall we convert this to a draft? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.