fix(popup): set modifiable failed when vim.api.nvim_buf_set_lines

[AlejandroSuero]

In the commit 0d0079c, I introduced a bug (sorry).

To reproduce:

:set nomodifiable
-- or
:lua vim.o.modifiable = false
-- and
:Telescope find_files

Note

I used Telescope cmdline in the demo bellow, but it will apply to any plugin using popup.create

Bug:

Note

It will launch the popup but it won't fill it

After the changes:

---

========================================
Testing:        /Users/aome/dev/nvim_plugins/plenary.nvim/tests/plenary/popup_spec.lua
Success ||      plenary.popup can create a very simple window
Success ||      plenary.popup can create a very simple window after 'set nomodifiable'
Success ||      plenary.popup can apply a highlight
Success ||      plenary.popup can create a border
Success ||      plenary.popup can apply a border highlight
Success ||      plenary.popup can ignore border highlight with no border
Success ||      plenary.popup can do basic padding
Success ||      plenary.popup can do padding and border
Success ||      plenary.popup borderchars can support multiple border patterns
Success ||      plenary.popup borderchars can support multiple patterns inside the borderchars
Success ||      plenary.popup what can be an existing bufnr
Pending ||      plenary.popup cursor not yet tested

Success:        11
Failed :        0
Errors :        0
========================================

[Conni2461]

the change looks super where, can you rebase this branch

because on your branch i cant find the original change, but its also not dropped in the changes. so i have no idea whats currently going on, other than the change doesnt look "correct".

The right image shows the current HEAD while the left side shows the diff from this PR

[AlejandroSuero]

@Conni2461 now it should show the changes correctly. Didn't notice that the branch was not showing the changes completely, sorry 😅

[Conni2461]

this just enables this globally. change this setting, we probably dont want this?!

[AlejandroSuero]

@Conni2461 I made the changes, kept it like the master branch and added the check in lua/plenary/window/border.lua because the error said that it was failing at line 219.

Now it works, but doesn't render the preview on the files. Don't know the reason.

plenary-feat-modifiable-popup.mp4

[Conni2461]

Now it works, but doesn't render the preview on the files. Don't know the reason.

this is a telescope issue, telescope creates the buffers for the file previewer. so we need to fix it here: https://github.com/nvim-telescope/telescope.nvim/blob/master/lua/telescope/previewers/buffer_previewer.lua#L428

also why dont we do vim.api.nvim_buf_set_option(self.bufnr, "modifiable", true) unconditionally? it always needs to be true, regardless of what vim.o.modifiable is

[AlejandroSuero]

With the changes made in this PR and in telescope.nvim#3077 now it works perfectly.

[Conni2461]

thanks :)