Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vim.notify(msg, vim.log.Level) for logger #540

Open
ten3roberts opened this issue Nov 9, 2023 · 0 comments · May be fixed by #578
Open

Use vim.notify(msg, vim.log.Level) for logger #540

ten3roberts opened this issue Nov 9, 2023 · 0 comments · May be fixed by #578

Comments

@ten3roberts
Copy link

Adding an option to log using vim.notify over the echo area will allow integration of tools such as nvim-notify and telescope notify history, as well as allow better navigation between different log messages as they are separated as different entries

lettertwo added a commit to lettertwo/plenary.nvim that referenced this issue May 8, 2024
[vim.notify](https://neovim.io/doc/user/lua.html#vim.notify()) is arguably a more ergonomic way of showing level-filtered messages to the user, and it also allows for custom providers and handling, like [nvim-notify](https://github.com/rcarriga/nvim-notify) or [noice](https://github.com/folke/noice.nvim) , to integrate messages from  `plenary.log`.

I'm not sure if it's a bad idea to make this the new default; it could certainly be a breaking change, but i think that the _intention_ of an author who has not overridden the default config probably aligns with the behavior of `nvim.notify`.

Fixes nvim-lua#540
@lettertwo lettertwo linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant