Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only consider raw command in output #931

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Only consider raw command in output #931

merged 3 commits into from
Aug 19, 2019

Conversation

tobixx
Copy link
Contributor

@tobixx tobixx commented Jul 12, 2019

... else it will not work for localized messages.

Example German output:

Führen Sie »apt list --upgradable« aus, um sie anzuzeigen.

... else it will not work for localized messages.

Example German output:
```
Führen Sie »apt list --upgradable« aus, um sie anzuzeigen.
```
Copy link
Collaborator

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to TheFuck, @tobixx.

Would you please add a couple tests for that?

@tobixx
Copy link
Contributor Author

tobixx commented Aug 10, 2019

@scorphus done

@nvbn nvbn merged commit 3bbe391 into nvbn:master Aug 19, 2019
@nvbn
Copy link
Owner

nvbn commented Aug 19, 2019

Looks good, thanks!

riley-martine pushed a commit to riley-martine/thefuck that referenced this pull request Dec 7, 2023
* Only consider raw command in output match

... else it will not work for localized messages.

Example German output:
```
Führen Sie »apt list --upgradable« aus, um sie anzuzeigen.
```

* added german output test

* make the linter happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants