Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudinary): handle blur modifier correctly #985

Merged
merged 3 commits into from
Sep 29, 2023
Merged

fix(cloudinary): handle blur modifier correctly #985

merged 3 commits into from
Sep 29, 2023

Conversation

PatrikBird
Copy link
Contributor

@PatrikBird PatrikBird commented Sep 14, 2023 •
edited
Loading

This fixes #983

@PatrikBird PatrikBird marked this pull request as draft September 14, 2023 14:26
@PatrikBird PatrikBird marked this pull request as ready for review September 27, 2023 07:14
@PatrikBird PatrikBird changed the title WIP: fix placeholder for cloudinary fix: placeholder for cloudinary Sep 27, 2023
Baroshem
Baroshem reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, very good Pr, please take a look at the comment I added :)

src/runtime/providers/cloudinary.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2387d47) 89.91% compared to head (f9c15de) 89.91%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files          44       44           
  Lines        2905     2906    +1     
  Branches      328      328           
=======================================
+ Hits         2612     2613    +1     
  Misses        292      292           
  Partials        1        1
Files Coverage Δ
src/runtime/providers/cloudinary.ts 96.42% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix: placeholder for cloudinary fix(cloudinary): handle blur modifier correctly Sep 29, 2023
@danielroe danielroe merged commit a5fe841 into nuxt:main Sep 29, 2023
2 checks passed
@danielroe danielroe mentioned this pull request Oct 2, 2023
Closed
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@PatrikBird @riddla
fix(cloudinary): handle blur modifier correctly (nuxt#985)
d7c1c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@Baroshem Baroshem Baroshem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholder creates bad request on cloudinary
4 participants
@PatrikBird @codecov-commenter @danielroe @Baroshem