chore: add types to ipx provider options #1132
Merged
+38
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atinux
changed the title
Atinux
approved these changes
Dec 12, 2023
pi0
reviewed
Dec 12, 2023
src/types/module.ts
Outdated
| animated: true | 'true' | ||
| } | ||
|
|
||
| export interface StaticIPXOptions extends Omit<IPXRuntimeConfig, 'alias'> { |
There was a problem hiding this comment.
Since after refactors i guess simply call interface IPXOtions..
pi0
reviewed
Dec 12, 2023
danielroe
reviewed
Dec 12, 2023
danielroe
reviewed
Dec 12, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
+ Coverage 70.47% 70.75% +0.27%
==========================================
Files 71 71
Lines 4030 4065 +35
Branches 383 384 +1
==========================================
+ Hits 2840 2876 +36
Misses 1165 1165
+ Partials 25 24 -1 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Dec 13, 2023
pi0
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework of #976