Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add export default to default config example #796

Merged
merged 1 commit into from
Jan 30, 2024
Merged

docs: add export default to default config example #796

merged 1 commit into from
Jan 30, 2024

Conversation

cngJo
Copy link
Contributor

@cngJo cngJo commented Jan 30, 2024

I noticed the missing export default in the JS file when copying it into my project.

Copy link

nuxt-studio bot commented Jan 30, 2024

Live Preview ready!

Name Edit Preview Latest Commit
TailwindCSS Edit on Studio ↗︎ View Live Preview 923ab6b

Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Configuration Export Modification
    The update made changes to a configuration file. It's now set up to allow other modules to use the tailored configurations straight away. This improves the ease of code reusability.

@ineshbose
Copy link
Collaborator

Thanks! I wonder if this should rather be module.exports = instead, but likely
not because Nuxt projects' package.json specify type: module, and Tailwind 3.3 has ESM support so I am okay with this! Thank you again 😃

@ineshbose ineshbose merged commit 8280b27 into nuxt-modules:main Jan 30, 2024
@cngJo
Copy link
Contributor Author

cngJo commented Jan 30, 2024

https://tailwindcss.nuxtjs.org/tailwind/config#tailwindconfig mentions, that you need to use ESM when not explicitly being in an .cjs file. That's why I used the ESM style in the PR.

You're welcome! And thanks for the instant merge 🎉

@cngJo cngJo deleted the patch-1 branch January 30, 2024 15:26
Copy link

netlify bot commented Mar 27, 2024

‼️ Deploy request for nuxt-tailwindcss rejected.

Name Link
🔨 Latest commit 923ab6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants