Warning & error suppression for LSP #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a problem with this PR but what is |
|
It is an lsp (language server protocol) for typescript. I was looking for an LSP to use with grammar.js. I asked in the Matrix channel for tree-sitter what LSP is commonly used to edit that file & was told typescript is the answer. If you check the grammar.js of other tree-sitter projects you will probably also find comments related to tsserver. |
|
ok, that makes sense that you'd use the typescript lsp for grammar.js. seem benign enough. |
mrdgo
pushed a commit
to mrdgo/tree-sitter-nu
that referenced
this pull request
Sep 23, 2024
This adds several warning & error suppressions for the tsserver lsp. Doesn't actually change any functionality (if you tree-sitter generate you will see that nothing would get changed). - add type docs to functions - supress tsserver errors (they are not actual errors, tsserver just can't properly diagnose the grammar.js) - add _ to unused arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several warning & error suppressions for the tsserver lsp. Doesn't actually change any functionality (if you tree-sitter generate you will see that nothing would get changed).