Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to new actions (alternative) #505

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

sholderbach
Copy link
Member

Alternative to #503

Using actions-rust-lang instead of actions-rs for setup. (nushell uses them for setup with integrated caching)

Remove build stage as this should also be covered by test.
clippy --all to see if this checks the examples as well.

Alternative to nushell#503

Using `actions-rust-lang` instead of `actions-rs` for
setup. (nushell uses them for setup with integrated caching)

Remove build stage as this should also be covered by test.
clippy --all to see if this checks the examples as well.
@sholderbach sholderbach added the chore Various work that should be done to keep the repo in a nice shape label Oct 30, 2022
@sholderbach
Copy link
Member Author

Difference in runtime from an empty cache to #503 is 3 mins vs 4 mins. But this one being 1 min faster might just be an artifact of the machine this job was running on. Choosing this one as the workflow file is simpler and more compact.

@sholderbach sholderbach merged commit f2ee704 into nushell:main Oct 30, 2022
@sholderbach sholderbach deleted the update-ci-alt branch October 30, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Various work that should be done to keep the repo in a nice shape
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant