Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab inline completion #498

Merged
merged 3 commits into from
Oct 22, 2022
Merged

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Oct 18, 2022

This PR makes nushell tab completion behave more like zsh/bash. Assuming quick_completions = true:

  • Changes Tab so that it completes instead of selecting the next menu item (arrow keys can be used for that)
  • Completion is "as far as possible". So, the entire word if there's a unique completion, or else up to the shared prefix of possible completions.
  • Gets rid of the quick completion behavior whereby a word was completed automatically as soon as the input came to have a unique completion.

See nushell/nushell#6802 to use this with nushell.

@fdncred
Copy link
Collaborator

fdncred commented Oct 22, 2022

I'm guessing we need to land this one so we don't have to point to @dandavison's repo?

@sholderbach
Copy link
Member

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants