fix: list_menu not accounting for index + indicator #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code didn't account for the index and the indicator in its calculation for the number of lines in the list_menu. Now the unicode_width of the indicator and the number of digits of the index are accountet for.
|
Good catch! The fix looks a bit gnarly but seems to work for me. |
|
I'm not that attached to my code. If someone has a better solution to fixing the problem, then this PR can be closed and a different solution implemented. |
|
I think with the current setup this is the way to go for now. Refactoring the menu layouting code can come later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
reedline_bug.mp4
The code didn't account for the index and the indicator in its calculation for the number of lines in the list_menu.
Now the unicode_width of the indicator and the number of digits of the index are accounted for.