Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with include_path -I parameter #8915

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Apr 17, 2023

Description

This PR fixes a problem with the -I parameter. I probably broke it when I added the --ide-check <number> parameter to limit the amount of errors are shown.

User-Facing Changes

Tests + Formatting

After Submitting

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #8915 (297ae75) into main (f0e0ab3) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8915      +/-   ##
==========================================
+ Coverage   68.16%   68.54%   +0.37%     
==========================================
  Files         636      636              
  Lines      101706   101713       +7     
==========================================
+ Hits        69331    69716     +385     
+ Misses      32375    31997     -378     
Impacted Files Coverage Δ
crates/nu-std/src/lib.rs 80.19% <100.00%> (+1.47%) ⬆️
src/command.rs 88.85% <100.00%> (ø)

... and 3 files with indirect coverage changes

@fdncred fdncred merged commit 06996d8 into nushell:main Apr 18, 2023
@fdncred fdncred deleted the fix_include_path_param branch April 18, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant