Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() #7412

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

webbedspace
Copy link
Contributor

@webbedspace webbedspace commented Dec 9, 2022

Description

While perusing Value.rs, I noticed the Value::int(), Value::float(), Value::boolean() and Value::string() constructors, which seem designed to make it easier to construct various Values, but which aren't used often at all in the codebase. So, using a few find-replaces regexes, I increased their usage. This reduces overall LOC because structures like this:

Value::Int {
  val: a,
  span: head
}

are changed into

Value::int(a, head)

and are respected as such by the project's formatter.
There are little readability concerns because the second argument to all of these is span, and it's almost always extremely obvious which is the span at every callsite.

User-Facing Changes

None.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@rgwood
Copy link
Contributor

rgwood commented Dec 9, 2022

image

Wow. This is an awesome change, thank you!

@rgwood rgwood merged commit 220b105 into nushell:main Dec 9, 2022
@webbedspace webbedspace deleted the find-replace-structs branch December 9, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants