Add arbitrary base math log
#7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new command `math log` that takes as a required positional argument a base. Specialized for `math log 2` and `math log 10` for better performance and precision that matches the expectations there. This leads to discontinuities in numerical error but should make a better trade-off for common usecases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new command
math logthat takes as a required positional argument a base.Specialized for
math log 2andmath log 10for better performance and precision that matches the expectations there. This leads to discontinuities in numerical error but should make a better trade-off for common usecases.Tests + Formatting
Example testing of the happy path