Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to hash file autocomplete #7398

Merged

Conversation

merelymyself
Copy link
Contributor

Description

Fixes #6741. Autocompleting a dir/file named something like foo#bar will now complete to `foo#bar`

User-Facing Changes

Files and directories with hashes will now autocomplete with quotation marks.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@sholderbach
Copy link
Member

Happy you are back! Thanks for the fix. Would you mind adding a test case?

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good!

@sholderbach sholderbach merged commit b39d797 into nushell:main Dec 8, 2022
@rgwood
Copy link
Contributor

rgwood commented Dec 8, 2022

This is a really nice improvement, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion of filenames containing # does not quote them
3 participants