Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve empty pipelines #7383

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Improve empty pipelines #7383

merged 2 commits into from
Dec 7, 2022

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Dec 7, 2022

Description

This fix changes pipelines to allow them to actually be empty. Mapping over empty pipelines gives empty pipelines. Empty pipelines immediately return None when iterated.

This removes a some of where Span::new(0, 0) was coming from, though there are other cases where we still use it.

User-Facing Changes

None

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@sophiajt sophiajt merged commit eaec480 into nushell:main Dec 7, 2022
@sophiajt sophiajt deleted the fix_pipeline_empty branch December 7, 2022 18:32
@sholderbach sholderbach added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants