Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated actions-rs/cargo GH action #7375

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

rgwood
Copy link
Contributor

@rgwood rgwood commented Dec 7, 2022

Our CI actions have a lot of warnings like this:

nu-fmt-clippy (ubuntu-20.04, stable)
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/[email protected]

It looks like actions-rs/cargo is abandoned. But the good news is we don't actually need it, we can just run cargo subcommands without a special action because we've already installed cargo with actions-rust-lang/setup-rust-toolchain.

@rgwood rgwood merged commit 5114dfc into nushell:main Dec 7, 2022
@sholderbach
Copy link
Member

Much nicer. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants