Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill: don't show signal example on windows #7353

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

nibon7
Copy link
Contributor

@nibon7 nibon7 commented Dec 5, 2022

Description

Windows doesn't support the --signal(-s) option, so don't show the example in help.

User-Facing Changes

N/A

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@rgwood
Copy link
Contributor

rgwood commented Dec 5, 2022

Good catch, thanks.

@rgwood rgwood merged commit 9fb9b16 into nushell:main Dec 5, 2022
@nibon7 nibon7 deleted the kill branch December 5, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants