fix upsert index of zero

[Kangaxx-0]

Description

Try to fix #7347, this pr does not fix the error message to upserting beyond 1 + the list's length doesn't work,, I feel this is still not explicit or general engouh, if we want to change, what would be the best message to be printed out ?

Add tests too

User-Facing Changes

(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

• cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
• cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
• cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

[rgwood]

Thanks for the PR!

Could we do this in a simpler way by just removing - 1 from this line?

nushell/crates/nu-command/src/filters/upsert.rs

Line 172 in db6c804

return Err(ShellError::AccessBeyondEnd(idx - 1, *span));

I think that should actually be:

return Err(ShellError::AccessBeyondEnd(idx, *span)); 

It seems like N in the index too large (max: N) error message is always off by 1. For example:

That should say max: 1 not max: 0, because 1 works:

[Kangaxx-0]

Thanks for the PR!

Could we do this in a simpler way by just removing - 1 from this line?

nushell/crates/nu-command/src/filters/upsert.rs

Line 172 in db6c804

return Err(ShellError::AccessBeyondEnd(idx - 1, *span));

I think that should actually be:

return Err(ShellError::AccessBeyondEnd(idx, *span)); 

It seems like N in the index too large (max: N) error message is always off by 1. For example:

That should say max: 1 not max: 0, because 1 works:

Good catch! I've made the change

[rgwood]

LGTM, thanks!

In the future, can you please include examples and/or screenshots in your PR descriptions? It will help the reviewers.