Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add background colors to the ansi command #7312

Merged
merged 1 commit into from
Dec 3, 2022
Merged

add background colors to the ansi command #7312

merged 1 commit into from
Dec 3, 2022

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Dec 1, 2022

Description

This PR adds the ability to easily specific background colors using the ansi command. It also allows you to use attributes.
image

I also updated the grid output to be clear that the output includes an escape character, represented here by \e.
image

User-Facing Changes

You can see a list of these new items with ansi --list with their long and short names.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks convenient. (although I'd struggle with all the existing shorthands)

@fdncred fdncred merged commit 6295b20 into nushell:main Dec 3, 2022
@fdncred fdncred deleted the add_bg_color_and_attrs branch December 3, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants