Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$env.config now always holds a record with only valid values #7309

Merged
merged 8 commits into from
Dec 10, 2022
Merged

$env.config now always holds a record with only valid values #7309

merged 8 commits into from
Dec 10, 2022

Commits on Dec 8, 2022

  1. $env.config is now a 'clean' record with only valid values

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    df93b08 View commit details
    Browse the repository at this point in the history

  2. into_config() muts a copy of the previous config

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a2d7893 View commit details
    Browse the repository at this point in the history

  3. New approach

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d7c9ca9 View commit details
    Browse the repository at this point in the history

  4. Revert nu-engine Cargo.toml change

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0ceddfc View commit details
    Browse the repository at this point in the history

  5. into_config() now produces actual errors

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d0562d6 View commit details
    Browse the repository at this point in the history

  6. On error, reconstruct existing config value

    @webbedspace
    webbedspace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d2253e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Try to improve tests

    @webbedspace
    webbedspace committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3beff14 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @webbedspace
    webbedspace committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    600889f View commit details
    Browse the repository at this point in the history