Update release script to nu v0.71 and use ubuntu-20.04 to build nu binary #7290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help with this. It would also be helpful to print out the variables in the first ~20 lines. It was difficult for me to debug without really knowing what these were supposed to be. I'd also like to land this PR #7277 before this one because it has some comments on running it manually. |
|
@hustcer Would you mind changing this to 20.04 vs 22.04? We think moving to the older version would help with the glibc issues. |
I agree with you, will change it to ubuntu-20.04 later |
hustcer
changed the title
sophiajt
pushed a commit
that referenced
this pull request
Dec 5, 2022
…nary (#7290) # Description 1. Update nu to v0.71 for release script 2. Remove the usage of `set-output` see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ 3. Use `ubuntu-20.04` instead of `ubuntu-latest` to fix #7282 To check the workflow running result see: https://github.com/hustcer/nu-release/actions/runs/3588720720/jobs/6040412953 # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
rgwood
added a commit
that referenced
this pull request
Dec 5, 2022
The release job was pinned to Ubuntu 20.04 to avoid glibc breakage in #7290. This PR updates the CI jobs to keep things consistent (it would sure be unpleasant if things worked in CI but not at release time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
set-outputsee: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ubuntu-20.04instead ofubuntu-latestto fixglibcversion too damn high? #7282To check the workflow running result see: https://github.com/hustcer/nu-release/actions/runs/3588720720/jobs/6040412953
User-Facing Changes
(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.