Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert string duration to named duration #6406

Merged
merged 1 commit into from
Aug 24, 2022
Merged

convert string duration to named duration #6406

merged 1 commit into from
Aug 24, 2022

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Aug 24, 2022

Description

This PR allows you to convert string durations into named durations.
Examples:

'7min' | into duration --convert sec
420 sec

Ideally, we'd have something that converts durations into named durations but I couldn't figure out how to do that. I'd welcome a PR that does it though. :)

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@fdncred fdncred merged commit 5ebfa10 into nushell:main Aug 24, 2022
@fdncred fdncred deleted the add_duration_conversion branch August 24, 2022 19:45
dheater pushed a commit to dheater/nushell that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant