Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up README #5718

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Clean up README #5718

merged 7 commits into from
Jun 7, 2022

Conversation

rgwood
Copy link
Contributor

@rgwood rgwood commented Jun 6, 2022

Description

The README was getting very long and some places were out of date. I've done a pass to update out-of-date info and remove some info that the book covers better.

@fdncred
Copy link
Collaborator

fdncred commented Jun 6, 2022

thanks. it's been needing this pass through for a while. although, I think I'd vote to keep the installation section.

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion maybe add a TOC at the top to quickly navigate to either pages in the same readme or to the appropriate page like I did it for reedline. This way, we can keep the full installation information (if up to date) there but can keep the easy and interesting to read stuff at the top.

Comment on lines -203 to -204
> config set line_editor.edit_mode "vi"
> config set path $nu.path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow yeah that is out of date

README.md Outdated

You can also find information on more specific topics in our [cookbook](https://www.nushell.sh/cookbook/).
If you're a developer who would like to contribute to Nu, we're working on a [book for developers](https://www.nushell.sh/contributor-book/) to help you get started. There are also [good first issues](https://github.com/nushell/nushell/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) to help you dive in.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Contributor book is not yet updated and thus this leads to a stub.

@rgwood
Copy link
Contributor Author

rgwood commented Jun 6, 2022

Thanks for the feedback; things got a bit busy over here but I’ll do another revision as soon as I have time.

@rgwood rgwood marked this pull request as draft June 6, 2022 20:21
@rgwood
Copy link
Contributor Author

rgwood commented Jun 7, 2022

OK, did another pass. Notable changes:

  • Updated CONTRIBUTING.md, it was very out of date
  • Added some quick-install info back to the installation section
  • Added a table of contents (the Markdown All in One extension is nice for this!)
  • Removed mention of the contributor book since it's currently a work in progress

It occurrect to me that the Philosophy section could use a rewrite; it's currently a bit crowded, has lots of info that doesn't really fit under "Philosophy". But I'll leave that for another time.

@rgwood rgwood marked this pull request as ready for review June 7, 2022 17:21
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@rgwood
Copy link
Contributor Author

rgwood commented Jun 7, 2022

Merging but just let me know if I got anything wrong.

@rgwood rgwood merged commit 56f6f68 into nushell:main Jun 7, 2022
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
* Clean up README

* Update CONTRIBUTING.md

* Another pass over the README. Table of contents, more install info

* add a little extra features definition

* fix Winget instructions

* Change winget instructions to nushell (easier to remember)

Co-authored-by: Darren Schroeder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants