Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and optimize the github release workflow: deliver binary package for more targets #5649

Merged
merged 1 commit into from
May 28, 2022

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented May 26, 2022

Description

Rewrite nushell github release workflow: we use nushell to release nushell now !
The new release workflow will be much easier to read and maintain, but all the release packages need to be tested to make sure that they work correctly for the next nu release.
All the release packages could be download here for testing purpose only: https://github.com/hustcer/nu-release/releases
Actions run result: https://github.com/hustcer/nu-release/actions/runs/2396235631

Release Packages Need To Be Tested:

  • nu-0.63.1-aarch64-apple-darwin.tar.gz
  • nu-0.63.1-aarch64-unknown-linux-gnu.tar.gz
  • nu-0.63.1-armv7-unknown-linux-gnueabihf.tar.gz
  • nu-0.63.1-x86_64-apple-darwin.tar.gz
  • nu-0.63.1-x86_64-pc-windows-msvc.msi
  • nu-0.63.1-x86_64-pc-windows-msvc.zip
  • nu-0.63.1-x86_64-unknown-linux-gnu.tar.gz
  • nu-0.63.1-x86_64-unknown-linux-musl.tar.gz

Binary packages could be downloaded here: https://github.com/hustcer/nu-release/releases

How to Test:

  1. Make sure each release package has the same file contents as before.
  2. Make sure nu could be ran successfully on that build target
  3. Run version make sure the build_target field is the same as current package claimed

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@hustcer hustcer changed the title 【Need More Test】Rewrite the github release workflow 【Need More Tests】Rewrite the github release workflow May 26, 2022
@hustcer

This comment was marked as duplicate.

@hustcer hustcer changed the title 【Need More Tests】Rewrite the github release workflow 【Call For Tests】Rewrite the github release workflow May 27, 2022
@hustcer hustcer changed the title 【Call For Tests】Rewrite the github release workflow 【Call For Test】Rewrite the github release workflow May 27, 2022
@fdncred
Copy link
Collaborator

fdncred commented May 27, 2022

@hustcer I ran the nu from nu-0.63.1-aarch64-apple-darwin.tar.gz on my m1max and it works. The only thing with apple is that it's a total pain to run executables like this because of gatekeeper. We really need to figure out how to make them a pkg or dmg and sign them somehow. any ideas about this?

@hustcer
Copy link
Contributor Author

hustcer commented May 27, 2022

@hustcer I ran the nu from nu-0.63.1-aarch64-apple-darwin.tar.gz on my m1max and it works. The only thing with apple is that it's a total pain to run executables like this because of gatekeeper. We really need to figure out how to make them a pkg or dmg and sign them somehow. any ideas about this?

I have no idea about such things, maybe we can do some research later.

@hustcer
Copy link
Contributor Author

hustcer commented May 27, 2022

@fdncred Can you test nu-0.63.1-aarch64-apple-darwin.tar.gz again? I have just changed the release script a lot, make a new release just now, and add a new test case

@fdncred
Copy link
Collaborator

fdncred commented May 27, 2022

@fdncred Can you test nu-0.63.1-aarch64-apple-darwin.tar.gz again? I have just changed the release script a lot, make a new release just now, and add a new test case

I can't right now. I'm at work.

@hustcer
Copy link
Contributor Author

hustcer commented May 27, 2022

Never mind, you can do it anytime

I can't right now. I'm at work.

@hustcer
Copy link
Contributor Author

hustcer commented May 28, 2022

I have tested 5 of the 8 release packages already, the other 3 should work theoretically

@hustcer
Copy link
Contributor Author

hustcer commented May 28, 2022

I have just found a smart way to check linux packages for aarch64 and armv7 here:
https://github.com/hustcer/setup-nu/actions/runs/2399601503
So nu-0.63.1-aarch64-apple-darwin.tar.gz is the last one to be checked.
I think it's ready for landing now

@hustcer hustcer marked this pull request as ready for review May 28, 2022 01:54
@hustcer hustcer changed the title 【Call For Test】Rewrite the github release workflow Refactor and optimize the github release workflow: deliver binary package for more targets May 28, 2022
@hustcer hustcer force-pushed the optimize/release-workflow branch from e04784d to 7feadea Compare May 28, 2022 02:06
@hustcer hustcer merged commit 6c07bc1 into nushell:main May 28, 2022
@hustcer hustcer deleted the optimize/release-workflow branch May 28, 2022 02:42
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants