Change embed-resource
dependency to slimmer winres
#5630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is not urgent in any way, it can wait to be merged until after today's release.
Description
Closes #5628. The Windows build now has 8 fewer crates.
This was mostly motivated by noticing the
vswhom
crate take ~30s to compile sometimes (probably because it builds C++ code).Before:
![image](https://user-images.githubusercontent.com/26268125/170145319-120845f4-def4-41cd-bd15-0c7880bca8c1.png)
After:
![image](https://user-images.githubusercontent.com/26268125/170145237-4c3463fb-7277-474c-9d76-9ea82511846e.png)
Tests
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass