Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for Rust 1.59 #4995

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Update README.md for Rust 1.59 #4995

merged 1 commit into from
Mar 27, 2022

Conversation

futile
Copy link
Contributor

@futile futile commented Mar 27, 2022

Since Cargo.toml now specifies strip = ..., and strip is only available in cargo >=1.59, specify that at least this version is required.

Description

Update README.md with the info that at least Rust 1.59 is required.

Ran into this in nixpkgs, where nushell 0.60 doesn't build with Rust 1.58 anymore, see: NixOS/nixpkgs#165473

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

Disclaimer: I haven't run any of the checks mentioned above (just edited the file on github).

Since `Cargo.toml` now specifies `strip = ...`, and `strip` is only available in cargo >=1.59, specify that at least this version is required.
@sophiajt
Copy link
Contributor

Thanks!

@sophiajt sophiajt merged commit 0c9dd6a into nushell:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants