Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for .nu files' mimetype #4813

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Icon for .nu files' mimetype #4813

merged 2 commits into from
Mar 10, 2022

Conversation

danimesq
Copy link
Contributor

Icon that should be displayed at every .nu script in a file explorer.

Later, a post-install script will be submitted; this script will install the mimetype+icon and the handler for doubleclicking/openning .nu files.

Icon that should be displayed at every .nu script in a file explorer.

Later, a post-install script will be submitted; this script will install the mimetype+icon and the handler for doubleclicking/openning .nu files.

Signed-off-by: Daniell Mesquita <[email protected]>
@fdncred
Copy link
Collaborator

fdncred commented Mar 10, 2022

@danimesq if i'm seeing the file correctly, it's named too generically. i'd like to see it named after the author and not just a mime-type please.

@danimesq
Copy link
Contributor Author

danimesq commented Mar 10, 2022

if i'm seeing the file correctly, it's named too generically. i'd like to see it named after the author and not just a mime-type please.

I'm open to do what the repo manager(s) (you and others) rather for/thinks is a better fit; BTW if I could counter propose:

There are already generic names like black-white, green-black, green-white-black-circle, nushell-round-black, etc.

Its nice to credit authors in filenames when those are from Discord and not committers - but in this PR's case, there's a committer so personally I don't think there's a need to credit in the file itself.

But I'm open to renaming it the way you think its a fit: named after the author.

As per request, using author name in icon. Also, using the updated name.

Signed-off-by: Daniell Mesquita <[email protected]>
@danimesq
Copy link
Contributor Author

Done.

@fdncred
Copy link
Collaborator

fdncred commented Mar 10, 2022

thanks for updating the name. i'd like to change those other icons by the name of the authors but they're lost in time since I've been collecting these for years.

@fdncred fdncred merged commit 675d30d into nushell:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants