Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sysinfo version from v0.22.2 to v0.23.5, close #3909 #4810

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Bump sysinfo version from v0.22.2 to v0.23.5, close #3909 #4810

merged 1 commit into from
Mar 10, 2022

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented Mar 10, 2022

Description

Bump sysinfo version from v0.22.2 to v0.23.5, close #3909

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@hustcer hustcer changed the title Bump version sysinfo from v0.22.2 to v0.23.5, close #3909 Bump sysinfo version from v0.22.2 to v0.23.5, close #3909 Mar 10, 2022
@sophiajt
Copy link
Contributor

thanks!

@sophiajt sophiajt merged commit ce690ed into nushell:main Mar 10, 2022
@sophiajt
Copy link
Contributor

I just thought of something - we don't use sysinfo for ps anymore. Does this still close the issue somehow?

@hustcer hustcer deleted the feature/upgrade branch March 10, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade sysinfo dep
2 participants