Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize features a bit #4807

Merged
merged 1 commit into from
Mar 10, 2022
Merged

reorganize features a bit #4807

merged 1 commit into from
Mar 10, 2022

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Mar 10, 2022

Description

I think zip-support needs to be part of default since it's used in to html (part of extracting themes from the binary), and i think trash-support should be part of default, just because. which would leave only dataframes in extra. let me know if you disagree.

also changed lto to thin

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@fdncred fdncred merged commit 14dc662 into nushell:main Mar 10, 2022
@fdncred fdncred deleted the reorganize_features branch March 10, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant