Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move completions to DeclId #4801

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Mar 9, 2022

Description

This will bind the name after the @ for custom completions to a universal DeclId that can later be used.

This should allow you to export externs and use completions that are inside the module.

Fixes #4785

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt sophiajt requested a review from kubouch March 10, 2022 02:19
@kubouch
Copy link
Contributor

kubouch commented Mar 10, 2022

This fixes it, thanks!

@kubouch kubouch merged commit 12bf23f into nushell:main Mar 10, 2022
@sophiajt sophiajt deleted the completion_decl_id branch September 2, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom completions do not work when not exported from a module
2 participants